Attention is currently required from: Furquan Shaikh, Julius Werner.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47823 )
Change subject: cbfstool: Move alignment/baseaddress handling into cbfs_add_component()
......................................................................
Patch Set 8:
(1 comment)
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/47823/comment/671d5dfe_19ee8824
PS8, Line 561: if (param.precompression || param.compression != CBFS_COMPRESS_NONE) {
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47823
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc6d68b2c7f30e5d136433adb3aec5a87053f992
Gerrit-Change-Number: 47823
Gerrit-PatchSet: 8
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 14 Jan 2021 03:52:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment