Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48564 )
Change subject: [WIP] soc/amd/cezanne: add GPIO definitions
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48564/1/src/soc/amd/cezanne/include...
File src/soc/amd/cezanne/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/48564/1/src/soc/amd/cezanne/include...
PS1, Line 138: #define GPIO_22_IOMUX_EMMC_PWR_CTRL 1
i'd assume that it's a typo in the picasso herader; see also the Mandolin schematics where it's emmc […]
Done.
New change has been uploaded.
https://review.coreboot.org/c/coreboot/+/48633
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48564
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67930267a89ba0c64ec7e40e2bfa30a0618d104b
Gerrit-Change-Number: 48564
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Assignee: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Dec 2020 02:46:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment