Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32414 )
Change subject: x86: Introduce RESET_VECTOR_IN_DRAM option ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32414/12/src/arch/x86/memlayout.ld File src/arch/x86/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/32414/12/src/arch/x86/memlayout.ld@... PS12, Line 38: #include "car.ld" Copied comment from abandoned CB:34913
KM: ... this RESET_VECTOR_IN_DRAM would also conditionalise uses of x86/car.ld in x86/memlayout.ld.
MD: I agree, however that causes a new problem -- not insurmountable but I'm still trying minimize changes outside the picasso directory. We're relying on the fsp2_0 driver that uses the symbols _car_relocatable_data_end and _car_region_end for what we need.
KM: Looks like preram_symbols_available() in symbols.h needs a fix too.
MD: Hmm, I overlooked that. However, since I need to keep them in my hybrid romstage for FSP anyway, I think that should stay as-is. It looks like vboot/common is the only place where that's used currently. The google implementation of vboot will run on the PSP and not the x86.
KM: new commentary With the lack of ENV_BOOTBLOCK, ENV_VERSTAGE and ENV_POSTCAR and with ENV_ROMSTAGE that you eventually might want to load as rmodule at dynamic address, I feel this entire memlayout.ld file might not be well suited for Picasso.