Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32485 )
Change subject: soc/intel/common: Add new PAD_CFG macro.
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32485/1/src/soc/intel/common/block/include/i...
File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
https://review.coreboot.org/#/c/32485/1/src/soc/intel/common/block/include/i...
PS1, Line 251:
Some macros have the extra indent to indicate it's a continuation line. […]
Aah I see. I like it aligned at same tab level, but that's just my personal opinion. We can leave it as is if you want :).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32485
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0332c64e2fa62ce29c772444606adbfdf9c9afc4
Gerrit-Change-Number: 32485
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 26 Apr 2019 21:51:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment