Attention is currently required from: Christian Walter, Julius Werner.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69445 )
Change subject: security/tpm: make tspi/crtm.c agnostic to log format
......................................................................
Patch Set 2:
(1 comment)
File src/security/tpm/tspi/log.c:
https://review.coreboot.org/c/coreboot/+/69445/comment/16a3aff5_2a1fc19f
PS1, Line 126: break;
What if the algorithm is not found?
Out parameter will be set to `VB2_HASH_INVALID` and `tspi_measure_cache_to_pcr()` will fail because `tlcl_extend()` will fail for such value.
I don't return an error for such case to not stop traversal as it can go on.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69445
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3013bd5f29f1412fbe646dc74d8946704b750a66
Gerrit-Change-Number: 69445
Gerrit-PatchSet: 2
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 16 Nov 2022 22:35:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment