Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45137 )
Change subject: drivers/aspeed/common: Support disabled P2A bridge ......................................................................
Patch Set 1: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/45137/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45137/1//COMMIT_MSG@7 PS1, Line 7: P2A nit: Mind adding a short sentence of what P2A means, please?
https://review.coreboot.org/c/coreboot/+/45137/1//COMMIT_MSG@26 PS1, Line 26: 2.5seconds add a space: `2.5 seconds`
https://review.coreboot.org/c/coreboot/+/45137/1/src/drivers/aspeed/common/a... File src/drivers/aspeed/common/ast_post.c:
https://review.coreboot.org/c/coreboot/+/45137/1/src/drivers/aspeed/common/a... PS1, Line 384: ast_set_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xa3, 0xcf, 0x80); /* Enable DVO */
line over 96 characters
If you want, feel free to place the comment on the previous line