Attention is currently required from: Kapil Porwal, Subrata Banik, Yu-Ping Wu.
Jon Murphy has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87031?usp=email )
Change subject: security/vboot: Add option for enabling ADB over network via GBB flag
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I mean, we can start building coreboot from the firmware-android branch as well if you think this is […]
FWIW coreboot is already built from the branch: https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/refs/h...
If those two changes were placed directly in the firmware-android-15949.B branch, we would get the same benefit, and coreboot would continue being cherry-picked.
That being said, I think there's still benefit to flushing it out and landing it on ToT. I'll follow up on my change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87031?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb3a69f20ae39baf482a748a00556268d0d0aef7
Gerrit-Change-Number: 87031
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 01 Apr 2025 02:38:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org