[coreboot-gerrit] [L] Change in coreboot[main]: mb/google/nissa: Create pujjogatwin variant

[Matt DeVillier (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Luca Lai, Nick Vaccaro, Paul Menzel, Roger Wang, Subrata Banik.

Matt DeVillier has posted comments on this change by Roger Wang. ( https://review.coreboot.org/c/coreboot/+/85329?usp=email )

Change subject: mb/google/nissa: Create pujjogatwin variant
......................................................................

Patch Set 13:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85329/comment/2bcbb4a2_c395b9e4?usp... :
PS9, Line 9: Create the pujjogatwin variant of nissa reference board by copying the
           : pujjoga files to a new directory named for the variant.
           : 
           : The difference between pujjoga and pujjogatwin is that pujjogatwin use
           : Twinlake CPU, so copying the pujjoga setting files to create new variant.
> > Hi Kapil,
> > Thank you for the comment.
> > I just uploaded a new patchset.
> > If this version is merged, I will add CONFIG_OVERRIDE_DEVICETREE="variants/$(CONFIG_VARIANT_DIR)/overridetree_pujjogatwin.cb" in config.pujjogatwin.
> > Thank you.
>
> you can override the device tree in this same CL itself
> config OVERRIDE_DEVICETREE
>    default "variants/$(CONFIG_VARIANT_DIR)/overridetree_pujjogatwin.cb" if BOARD_GOOGLE_PUJJOGATWIN
>    default "variants/\$(CONFIG_VARIANT_DIR)/overridetree.cb"

please do this, zero reason to put it in the .config when it's necessary and not subject to change