Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38414 )
Change subject: ec/google/wilco: Set minimum UCSI_ACPI region length ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38414/3/src/ec/google/wilco/chip.c File src/ec/google/wilco/chip.c:
https://review.coreboot.org/c/coreboot/+/38414/3/src/ec/google/wilco/chip.c@... PS3, Line 30: UCSI_MIN_ALLOC_REGION_LEN Could you add a comment describing why this specific allocation needs to be large enough so it doesn't end up in the IMD small region. otherwise I'm sure this will confuse someone in the future.
https://review.coreboot.org/c/coreboot/+/38414/3/src/ec/google/wilco/chip.c@... PS3, Line 184: looks like a tab?