[coreboot-gerrit] [M] Change in coreboot[master]: soc/amd/common/acpi: Implement DTTS Proposal

[EricKY Cheng (Code Review)]

Attention is currently required from: Raul Rangel, Jason Nien, Matt DeVillier, Paul Menzel, Eric Lai, Martin Roth, Tim Van Patten, Eric Peers, LeilaCY Lin, Jason Glenesk, Dtrain Hsu, Caveh Jalali, Tim Wawrzynczak, Fred Reitberger, Karthikeyan Ramasubramanian, Boris Mittelberg, Felix Held.

EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68471 )

Change subject: soc/amd/common/acpi: Implement DTTS Proposal
......................................................................

Patch Set 57:

(1 comment)

File src/soc/amd/common/acpi/DTTS.asl:

https://review.coreboot.org/c/coreboot/+/68471/comment/4bad1d6f_2bd5660e 
PS39, Line 21:         //Set table A as default table after power on SUT
             :         If (_SB.PRTN == 7)
             :         {
             :             _SB.DDEF()
             :             Store(0,_SB.PRTN)
             :             Return (Zero)
             :         }
> Is it possible to power on with the lid closed, in laptop mode, or with the sensor >45C?   If so, th […]

Hi Tim,

For your suggestion, I would like to use this as workaround if it didn't affect the feature functionality. We can optimize this in another CL.

As you mentioned in above comments, we can discuss power states and EC behavior on tracker b/232946420 with Elthan Huang.

As I know coreboot will call dptc() once at EC.asl initialization and EC will trigger 3 desktop/laptop mode switch events during power on process without mode change.

Follow thermal team's proposal, table A is the first table during power on. I think I force to set table A as first table without assuming the thermal table switch conditions and EC behavior is one of the ways to achieve the goal.

BR,
Eric KY Cheng