Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26447 )
Change subject: device: Introduce pcidev_on_root() and friends
......................................................................
Patch Set 25:
(1 comment)
https://review.coreboot.org/c/coreboot/+/26447/25/src/device/device_const.c
File src/device/device_const.c:
https://review.coreboot.org/c/coreboot/+/26447/25/src/device/device_const.c@...
PS25, Line 43: result = 0;
Why didn't we put a comment here indicating why this function sometimes doesn't work? I assume it's […]
Well.. comment was not requested during the review and at least I had hoped in May 2018 that we can just throw this function out the window fast.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/26447
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie20598d48b4cf6e35e45fc90804bad4728437fc6
Gerrit-Change-Number: 26447
Gerrit-PatchSet: 25
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 26 Sep 2019 17:37:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment