Asami Doi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34535 )
Change subject: lib: Throw an error when ramdisk is present but initrd.size is 0 ......................................................................
Patch Set 5:
(4 comments)
I changed the purpose of this CL from avoiding a fail to throwing an error when initrd size is 0 even though ramdisk is present.
I guess there is something wrong in the integrated LinuxBoot so I will investigate it.
https://review.coreboot.org/c/coreboot/+/34535/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34535/2//COMMIT_MSG@9 PS2, Line 9: avoid
avoids
Done
https://review.coreboot.org/c/coreboot/+/34535/2//COMMIT_MSG@11 PS2, Line 11: don't know extract
Do you mean: don’t know how to?
Sorry, this part doesn't make sense at all. I updated the description.
https://review.coreboot.org/c/coreboot/+/34535/2//COMMIT_MSG@15 PS2, Line 15: Change-Id: I85aa33d2c2846b6b3a58df834dda18c47433257d
Please switch the lines, so the Signed-off-by line is at the end.
Done
https://review.coreboot.org/c/coreboot/+/34535/3/src/lib/fit_payload.c File src/lib/fit_payload.c:
https://review.coreboot.org/c/coreboot/+/34535/3/src/lib/fit_payload.c@249 PS3, Line 249: size
I don't like that this will silently fail if ramdisk is present, but the size is zero. […]
Ok, I added new if-statement to throw an error when the initrd size is 0 and updated the description in this CL.