Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48764/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48764/1//COMMIT_MSG@10 PS1, Line 10: Hence, libgfxinit : has a new Kconfig setting now for the PCH.
I'd move `now` earlier in the sentence: […]
Done
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 127: SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE
let's merge as-is and revisit, when CNL got dropped
Done (I think it's ok to have a value even for Cannon Lake here, only the guarding dependencies above would be problematic).
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 128: SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE
let's merge as-is and revisit, when CNL got dropped
Done