Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/27221 )
Change subject: mb/google/poppy/variants/nocturne: fix FPMCU IRQ sensitivity ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/27221/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nocturne/gpio.c:
https://review.coreboot.org/#/c/27221/1/src/mainboard/google/poppy/variants/... PS1, Line 138: NONE
If signal is active low, why did you change this definition from "_INVERT" ? IF it's a double-mappi […]
I've talked with Duncan and Aaron about this, and they have better explained to me how and where the various definitions come into play, and based on their input, your change with regard to removing "_INVERT" should be fine, please ignore my last comment.