Attention is currently required from: Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49303 )
Change subject: cpu/x86/mpinit: Serialize microcode updates for HT threads
......................................................................
Patch Set 4:
(1 comment)
File src/cpu/x86/sipi_vector.S:
https://review.coreboot.org/c/coreboot/+/49303/comment/7b80f0bf_135d040e
PS4, Line 132: Assuming that only pre-FIT platforms with Hyper-Threading enabled and at
: * most 8 threads will ever run into this condition, the boot delay is negligible.
that is still true for chromeos as this code path would never be taken. […]
Sorry I was just being slightly nitpicky 😊 you are right we update ucode in parallel later on.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49303
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27bf5177859c12e92d6ce7a2966c965d7262b472
Gerrit-Change-Number: 49303
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Wed, 27 Jan 2021 21:13:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment