build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34724 )
Change subject: soc/intel/common: Implement power-failure-state handling ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34724/4/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/pmclib.h:
https://review.coreboot.org/c/coreboot/+/34724/4/src/soc/intel/common/block/... PS4, Line 222: void pmc_soc_set_afterg3_en(pci_devfn_t, bool on); function definition argument 'pci_devfn_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/34724/4/src/soc/intel/common/block/... PS4, Line 223: void pmc_set_power_failure_state(pci_devfn_t); function definition argument 'pci_devfn_t' should also have an identifier name