Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45341 )
Change subject: soc/intel/common/block/cse: Refactor cse_request_global_reset() function ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45341/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/45341/1/src/soc/intel/common/block/... PS1, Line 666: cse_send_global_reset
The purpose of this is to unify reset handling across SoCs. […]
Ack
https://review.coreboot.org/c/coreboot/+/45341/1/src/soc/intel/common/block/... PS1, Line 675: hfs1.data = me_read_config32(PCI_ME_HFSTS1); : if (hfs1.fields.operation_mode) : goto ret;
This check is already performed by `cse_is_global_reset_allowed()` in `cse_request_global_reset()`.
Ack