Josie Nordrum has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45274 )
Change subject: lib: add ENV_SMM check to setup_preram_cache ......................................................................
lib: add ENV_SMM check to setup_preram_cache
Add check in setup_preram_cache to return if ENV_SMM is true. This avoids false warning that post-RAM FMAP is accessed too early caused by ENV_ROMSTAGE_OR_BEFORE evaluation in SMI handler.
BUG=b:167321319 BRANCH=None TEST=None
Signed-Off-By: Josie Nordrum josienordrum@google.com Change-Id: I3a4c199c42ee556187d6c4277e8793a36e4d493b --- M src/lib/fmap.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/45274/1
diff --git a/src/lib/fmap.c b/src/lib/fmap.c index e1e6a57..fc51122 100644 --- a/src/lib/fmap.c +++ b/src/lib/fmap.c @@ -46,6 +46,9 @@ if (CONFIG(NO_FMAP_CACHE)) return;
+ if (ENV_SMM) + return; + if (!ENV_ROMSTAGE_OR_BEFORE) { /* We get here if ramstage makes an FMAP access before calling cbmem_initialize(). We should avoid letting it come to that,