Attention is currently required from: Дмитрий Понаморев, Mariusz Szafrański, Paul Menzel, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Patrick Rudolph, King Sumo. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57194 )
Change subject: mb/teleplatforms/D4E4S16P8: Add new CRB teleplatforms/D4E4S16P8 ......................................................................
Patch Set 19:
(6 comments)
File src/mainboard/teleplatforms/D4E4S16P8/Kconfig:
https://review.coreboot.org/c/coreboot/+/57194/comment/d151c591_4c33f0c0 PS17, Line 14: ##
I'll adjust the licenses to one-liners.
Done
File src/mainboard/teleplatforms/D4E4S16P8/Kconfig:
https://review.coreboot.org/c/coreboot/+/57194/comment/a1a67915_13f2e5fd PS19, Line 31: default "1.0.12" This should be explicitly set only for a release to avoid mistaking development builds as releases. Seems like src/Kconfig:config LOCALVERSION will achieve the same thing.
File src/mainboard/teleplatforms/D4E4S16P8/gpio.h:
https://review.coreboot.org/c/coreboot/+/57194/comment/fb54c321_d29a2e7f PS18, Line 9: const struct dnv_pad_config D4E4S16P8_gpio_table[] = {
No data, only prototypes and defines in .h files.
Done
File src/mainboard/teleplatforms/D4E4S16P8/hsio.h:
https://review.coreboot.org/c/coreboot/+/57194/comment/e902a849_7d0e4b09 PS18, Line 9: const BL_HSIO_INFORMATION D4E4S16P8_hsio_config[] = {
No data, only prototypes and defines in .h files.
Done
File src/mainboard/teleplatforms/D4E4S16P8/ramstage.c:
https://review.coreboot.org/c/coreboot/+/57194/comment/ddcbf45f_0d129759 PS18, Line 28: if (tmp == 0x3f/*?*/ || (tmp < 0x20 || tmp > 0x7f)) {
I'll recude this to BIOS_SPEW. […]
Done
File src/mainboard/teleplatforms/D4E4S16P8/smbus.c:
https://review.coreboot.org/c/coreboot/+/57194/comment/2e709a89_ce4d6f5c PS17, Line 81: .device = 0x19df, /* Denverton SMBus0 "Legacy" device id */
This file is not specific to your board, I'll remove it here. […]
Done