[coreboot-gerrit] Change in ...coreboot[master]: drivers/wifi: Add generic WiFi driver

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33155 )

Change subject: drivers/wifi: Add generic WiFi driver
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/33155/4/src/drivers/intel/wifi/chip.h 
File src/drivers/intel/wifi/chip.h:

https://review.coreboot.org/#/c/33155/4/src/drivers/intel/wifi/chip.h@19 
PS4, Line 19: #include "drivers/wifi/generic_wifi.h"
> +1. This should not be required.

Sure will remove it.

https://review.coreboot.org/#/c/33155/4/src/drivers/wifi/generic.c 
File src/drivers/wifi/generic.c:

https://review.coreboot.org/#/c/33155/4/src/drivers/wifi/generic.c@195 
PS4, Line 195: )
> Was the check for !config->wake dropped intentionally?

In one of the previous comments, GPE0 can be a wake up source which can take the value of 0. Hence it was dropped.