build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34501 )
Change subject: Framework to get settings from RW_VPD to configure FSP UPD
......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34501/6/src/mainboard/ocp/monolake/...
File src/mainboard/ocp/monolake/romstage.c:
https://review.coreboot.org/c/coreboot/+/34501/6/src/mainboard/ocp/monolake/...
PS6, Line 77: const char *board_upd_vars[] = {FSP_VAR_HYPERTHREADING};
char * array declaration might be better as static const
https://review.coreboot.org/c/coreboot/+/34501/6/src/mainboard/ocp/monolake/...
PS6, Line 121: if (vpd_decode_string(rw_vpd_size, rw_vpd_addr, &consumed,
line over 96 characters
https://review.coreboot.org/c/coreboot/+/34501/6/src/mainboard/ocp/monolake/...
PS6, Line 122: board_vpd_process, (void *)UpdData) == VPD_DECODE_FAIL)
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34501
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice6ffe3f7a14c7f09637c5dcfc47e551a57f42f1
Gerrit-Change-Number: 34501
Gerrit-PatchSet: 6
Gerrit-Owner: jonzhang@fb.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jonzhang@fb.com
Gerrit-Reviewer: Łukasz Siudut
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 26 Jul 2019 20:17:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment