Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37781 )
Change subject: soc/intel/tigerlake: Update ACPI files ......................................................................
Patch Set 15:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37781/15//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37781/15//COMMIT_MSG@12 PS15, Line 12: also mentioned that you have use ASL2.0 code syntax for newer code addition
https://review.coreboot.org/c/coreboot/+/37781/15/src/soc/intel/tigerlake/ac... File src/soc/intel/tigerlake/acpi/pch_clock_ctl.asl:
https://review.coreboot.org/c/coreboot/+/37781/15/src/soc/intel/tigerlake/ac... PS15, Line 20: PCR_BASE_ADDRESS don't need if required use CONFIG_PCR_BASE_ADDRESS directly
https://review.coreboot.org/c/coreboot/+/37781/15/src/soc/intel/tigerlake/ac... PS15, Line 21: 0xAD0000 You don't need this
https://review.coreboot.org/c/coreboot/+/37781/15/src/soc/intel/tigerlake/ac... PS15, Line 25: OperationRegion (ICLK, SystemMemory, PCR_BASE_ADDRESS + ICLK_PCR_OFFSET, 0x40) you can use this rather those hardcoding logic
OperationRegion (ICLK, SystemMemory, Add (PCRB (PID_ISCLK), R_ICLK_PCR_CAMERA1), 0x40)