Attention is currently required from: Angel Pons, Michael Niewöhner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56071 )
Change subject: supermicro/x11-lga1151-series: Remove SkipExtGfxScan = 1 ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
Does just `PrimaryDisplay = Display_PEG` work with both an external GPU and the BMC VGA?
Ah, got it. FSP only takes the `PrimaryDisplay` UPD into account if the "ExtGfxScan" is performed. Otherwise an internal `PrimaryDisplay` variable that is initialized to `IGD` takes precedence. (I've been asking Intel to document the interdependencies of UPDs for years, they'll never learn.)
Too bad. What we could do is to try to optimize the case that IGD is disabled, i.e. a global `if (!is_dev_enabled(IGD)) SkipExtGfxScan = 1;`. Probably not worth any hassle, though.
I agree to the `SkipExtGfxScan` change now. But it would be nice to move the `SkipExtGfxScan = 0` setting to the override tree that also enables the IGD. (Actually, I'd prefer the IGD to be always enabled or have a Kconfig for it. It's not board specific, hence doesn't belong in the devicetree.)