Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33114 )
Change subject: Makefile.inc: Fix compilation issue with !CONFIG_STAGE_RAMSTAGE ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/33114/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33114/5//COMMIT_MSG@14 PS5, Line 14: >> rmodules_$(ARCH-ramstage-y) will evaluate as rmodules_
This one doesn't matter though, right?
sorry, i didn't get your point. compiler won't be able to understand "rmodules_" and throw compilation error
https://review.coreboot.org/#/c/33114/5/src/cpu/x86/Makefile.inc File src/cpu/x86/Makefile.inc:
https://review.coreboot.org/#/c/33114/5/src/cpu/x86/Makefile.inc@20 PS5, Line 20: ifeq ($(CONFIG_STAGE_RAMSTAGE),y)
If we have the Makefile dependencies correct this guard really shouldn't be needed, I think.
In case of CONFIG_RAMPAYLOAD is enable (means without ramstage) somehow we have to compile this file with any previous stage hence we need this Makefile.