build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35171 )
Change subject: arch/ppc64: add arch_timer ......................................................................
Patch Set 4:
(6 comments)
https://review.coreboot.org/c/coreboot/+/35171/4/src/arch/ppc64/include/arch... File src/arch/ppc64/include/arch/asm.h:
https://review.coreboot.org/c/coreboot/+/35171/4/src/arch/ppc64/include/arch... PS4, Line 17: #define ENDPROC(name) \ Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/c/coreboot/+/35171/4/src/arch/ppc64/include/arch... PS4, Line 21: #define ENTRY_WITH_ALIGN(name, bits) \ Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/c/coreboot/+/35171/4/src/arch/ppc64/include/arch... PS4, Line 25: name: labels should not be indented
https://review.coreboot.org/c/coreboot/+/35171/4/src/arch/ppc64/include/arch... PS4, Line 29: #define END(name) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/35171/4/src/arch/ppc64/include/arch... PS4, Line 30: .size name, .-name space required before that '-' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35171/4/src/arch/ppc64/include/arch... PS4, Line 55: #define MAKE_REGISTER_ACCESSORS(reg) \ Macros with complex values should be enclosed in parentheses