Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47151 )
Change subject: drivers/intel/gma: Add Kconfig option for vbt data size
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47151/3/src/drivers/intel/gma/Kconf...
File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/47151/3/src/drivers/intel/gma/Kconf...
PS3, Line 64: default 9 if SOC_INTEL_TIGERLAKE
Wouldn't it be better to do this in soc/intel/tigerlake rather than adding a check here? I suspect that as we go forward, we will see more platforms requiring bigger VBT_DATA_SIZE_KB. In that case, it would be best to have this configuration live within SoC Kconfig rather than changing the driver Kconfig for every platform and adding "if SOC_*".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47151
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia294fc94ce759666fb664dfdb910ecd403e6a2e9
Gerrit-Change-Number: 47151
Gerrit-PatchSet: 3
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Wed, 04 Nov 2020 18:52:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment