[coreboot-gerrit] Change in ...coreboot[master]: drivers/nvidia: Add PCI mapped option rom driver

[Name of user not set (Code Review)]

Name of user not set #1002090 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29676 )

Change subject: drivers/nvidia: Add PCI mapped option rom driver
......................................................................

Patch Set 2:
> Patch Set 2: -Code-Review
>
> I suspect that it will work if I'll use the vbios dumped from running OS under lenovo bios rather than the vbios extracted from bios dump. Because as I found out earlier (and mentioned on irc) lenovo bios patches vbios at runtime and changes PCI device id from 0ffb to 0ffc.
>
> I'm don't mind using vbios dumped from running OS, but if that's the case than we must explicitly mention it in the docs.

K2000M should be ffb and k1000M should be ffc. I have a dump from a running system for k2000m which has ffb. Are you sure it's changing at runtime ? You can get the rom from nouveau's debugfs and use https://github.com/awilliam/rom-parser to confirm.