Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41385 )
Change subject: soc/intel/tigerlake: Move PMC PCI resources under PMC device ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41385/3/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.c:
https://review.coreboot.org/c/coreboot/+/41385/3/src/soc/intel/tigerlake/chi... PS3, Line 135: __weak void soc_pmc_read_resources(struct device *dev) {} Why is this weak?
https://review.coreboot.org/c/coreboot/+/41385/3/src/soc/intel/tigerlake/chi... PS3, Line 154: static struct device_operations pmc_ops Why not just extern this here and make it a global object in pmc.c?
https://review.coreboot.org/c/coreboot/+/41385/3/src/soc/intel/tigerlake/chi... PS3, Line 159: .acpi_name = &soc_acpi_name, We can define the pmc acpi_name funciton in pmc.c compilation unit and just return "PMC" from there.