[coreboot-gerrit] Change in coreboot[master]: mb/google/kukui: Support eDP panels via PS8640

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34516 )

Change subject: mb/google/kukui: Support eDP panels via PS8640
......................................................................

Patch Set 45:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34516/40/src/mainboard/google/kukui... 
File src/mainboard/google/kukui/Kconfig:

https://review.coreboot.org/c/coreboot/+/34516/40/src/mainboard/google/kukui... 
PS40, Line 49: 	select DRIVER_PARADE_PS8640 if KUKUI_HAS_PS8640
> Well, you need the long 'if BOARD_... || BOARD... || BOARD... […]

Ack

https://review.coreboot.org/c/coreboot/+/34516/40/src/mainboard/google/kukui... 
File src/mainboard/google/kukui/panel_ps8640.c:

https://review.coreboot.org/c/coreboot/+/34516/40/src/mainboard/google/kukui... 
PS40, Line 72: 	ps8640_panel.edid.mode.name = mode_name;
> Why does ps8640_get_edid() not do that? Shouldn't we rather add it to that function?

let's do that in a follow up commit