[coreboot-gerrit] Change in coreboot[master]: mb/google/hatch/variants/hatch: Set PCH Thermal Threshold value to 77...

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33147 )

Change subject: mb/google/hatch/variants/hatch: Set PCH Thermal Threshold value to 77 deg C
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33147/6/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/hatch/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/33147/6/src/mainboard/google/hatch/... 
PS6, Line 57: .pch_thermal_trip = 77,
> You can add this to baseboard/devicetree.cb: […]

We have done this change and it works fine. Thanks Furquan for this suggestion. For caution, will add below as comment NOTE.

+   # NOTE: if any variant wants to override this value, use the same format
+   # as register "common_soc_config.pch_thermal_trip" = "value", instead of
+   # putting it under register "common_soc_config" in overridetree.cb file.
+   register "common_soc_config.pch_thermal_trip" = "77"