Attention is currently required from: Tarun Tuli, Subrata Banik.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74256 )
Change subject: soc/intel/: Store CSE firmware version into cbmem table
......................................................................
Patch Set 7:
(2 comments)
File src/soc/intel/alderlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/74256/comment/cb5d3bb3_d68d51e1
PS6, Line 235: DRIVERS_INTEL_ISH
we don't need this check as SOC_INTEL_STORE_CSE_FPT_PARTITION_VERSION already depends on DRIVERS_INT […]
Ack
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74256/comment/e58cf5d0_98c8911f
PS6, Line 1184: DRIVERS_INTEL_ISH
don't need this.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74256
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I923049d2f1f589f87e1a29e1ac94af7f5fccc2c8
Gerrit-Change-Number: 74256
Gerrit-PatchSet: 7
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Mon, 10 Apr 2023 14:31:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment