Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36963 )
Change subject: cpu/amd/fam10: Drop support ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36963/10/src/cpu/x86/lapic/lapic_cp... File src/cpu/x86/lapic/lapic_cpu_init.c:
https://review.coreboot.org/c/coreboot/+/36963/10/src/cpu/x86/lapic/lapic_cp... PS10, Line 145: #if !CONFIG(CPU_AMD_MODEL_10XXX) \ This is currently wrong, can you make a separate commit please.
Given that 206ax and 2065x (PARALLEL_MP=y) do not enter here, you could make mdelay() unconditional?
https://review.coreboot.org/c/coreboot/+/36963/10/src/device/hypertransport.... File src/device/hypertransport.c:
https://review.coreboot.org/c/coreboot/+/36963/10/src/device/hypertransport.... PS10, Line 469: unsigned int hypertransport_scan_chain(struct bus *bus) Not called from removed cpu/amd code? I would split device/hypertransport changes to followup work and see if we want to keep any of it around.