Attention is currently required from: Dinesh Gehlot, Jeremy Compostella, Kapil Porwal, Martin L Roth, Nick Vaccaro, Ronak Kanabar, Sean Rhodes, Subrata Banik.
Jérémy Compostella has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/81080?usp=email )
Change subject: soc/intel/alderlake: Correctly set CNVi Reset and Clkreq pins
......................................................................
Patch Set 9:
(1 comment)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/81080/comment/0a158690_fbbf2a6a?usp... :
PS9, Line 842: /*
Isn't a board design specific topic ? Should it be handled in src/mainboard/... ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81080?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib534d3cfe888c1c538267caaf324c8ae743da496
Gerrit-Change-Number: 81080
Gerrit-PatchSet: 9
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Jeremy Compostella
jeremy.compostella@intel.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: srinivas.kulkarni@intel.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jeremy Compostella
jeremy.compostella@intel.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Comment-Date: Fri, 30 Aug 2024 17:22:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No