16 Oct
2020
16 Oct
'20
10:46 p.m.
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46506 )
Change subject: drivers/uart: Fix control flow DEADCODE issue ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46506/2/src/drivers/uart/acpi/acpi.... File src/drivers/uart/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/46506/2/src/drivers/uart/acpi/acpi.... PS2, Line 77: acpi_device_write_gpio(&config->irq_gpio); : irq_gpio_index++;
Reading back over what this is doing, even though this is the first pin added, it's probably best to […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/46506
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79f85f05b78e5569615ae4c4f7c81cc85c3999c9
Gerrit-Change-Number: 46506
Gerrit-PatchSet: 4
Gerrit-Owner: John Zhao john.zhao@intel.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 16 Oct 2020 20:46:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment