Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78129?usp=email )
Change subject: mb/intel/glkrvp: Move selects from Kconfig.name to Kconfig ......................................................................
mb/intel/glkrvp: Move selects from Kconfig.name to Kconfig
Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files.
Change-Id: I817faab0438a35d2e8859342e7c2b2dbaa0afeeb Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/78129 Reviewed-by: Martin L Roth gaumless@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/intel/glkrvp/Kconfig M src/mainboard/intel/glkrvp/Kconfig.name 2 files changed, 4 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved
diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig index c2584f3..5a1ae43 100644 --- a/src/mainboard/intel/glkrvp/Kconfig +++ b/src/mainboard/intel/glkrvp/Kconfig @@ -13,6 +13,10 @@ select DRIVERS_I2C_DA7219 select SOC_ESPI
+config BOARD_INTEL_GLKRVP + select BOARD_INTEL_BASEBOARD_GLKRVP + select BASEBOARD_GLKRVP_LAPTOP + if BOARD_INTEL_BASEBOARD_GLKRVP
config BASEBOARD_GLKRVP_LAPTOP diff --git a/src/mainboard/intel/glkrvp/Kconfig.name b/src/mainboard/intel/glkrvp/Kconfig.name index b0cfdc5..0502c4c 100644 --- a/src/mainboard/intel/glkrvp/Kconfig.name +++ b/src/mainboard/intel/glkrvp/Kconfig.name @@ -1,4 +1,2 @@ config BOARD_INTEL_GLKRVP bool "Glkrvp" - select BOARD_INTEL_BASEBOARD_GLKRVP - select BASEBOARD_GLKRVP_LAPTOP