[coreboot-gerrit] [L] Change in coreboot[main]: treewide: Add generation of CFR Tables

[Angel Pons (Code Review)]

Attention is currently required from: Arthur Heymans, Martin L Roth, Maximilian Brune.

Angel Pons has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/82494?usp=email )

Change subject: treewide: Add generation of CFR Tables
......................................................................

Patch Set 7:

(2 comments)

File src/lib/coreboot_table.c:

https://review.coreboot.org/c/coreboot/+/82494/comment/48c459bf_45623fd7?usp... :
PS7, Line 568: __weak
> There is a use case on the prodrive atlas baord, that needs to update the SOT tables in runtime (so  […]

What does Atlas need to do? If possible, I'd suggest having something like `void __weak mainboard_update_sot_table(void *sot_buf, size_t size) {}` (empty weak definition) and call it from `write_sot_table()`.

https://review.coreboot.org/c/coreboot/+/82494/comment/55dd46d1_e5d026e2?usp... :
PS7, Line 575: 	size_t size = cbfs_load("fallback/sot", sot_buf, MAX_SOT_SIZE);
Is there a way to get the uncompressed size of a CBFS file at runtime? If so, it would be nice to use it to avoid allocating and then deallocating stuff in CBMEM, as well as to log a more detailed error when SOT size exceeds `MAX_SOT_SIZE` (and by how much).