Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46326 )
Change subject: soc/amd/common: Add weak function definitions to get ioapic IDs ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46326/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46326/1//COMMIT_MSG@8 PS1, Line 8:
marking resolved
I'm a bit confused by the answer. If these functions are supposed to return constant values, Kconfig is the usual way to solve this. We try to avoid weak symbols as much as possible as they often hide errors in code that would otherwise not build at all.
Please not that we are talking about Kconfig options that are _not_ visible to the user. These would get their defaults overridden by SoC specific code.
https://review.coreboot.org/c/coreboot/+/46326/1//COMMIT_MSG@15 PS1, Line 15: MADT.
marking resolved
If I understand it correctly you tested that the follow up patch doesn't regress non-picasso builds? If you tested a different or altered commit, please always mention that in the commit message. With this commit alone, there is nothing testable as the new functions are not called yet, AFAICS.