Attention is currently required from: Shelley Chen, mturney mturney, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50587 )
Change subject: sc7280: reserved wlan & wpss dram memory regions ......................................................................
Patch Set 28:
(4 comments)
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117211): https://review.coreboot.org/c/coreboot/+/50587/comment/830f59fb_6ae4ca9a PS28, Line 22: REGION_SIZE(dram_wlan) / KiB); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117211): https://review.coreboot.org/c/coreboot/+/50587/comment/bfd9decb_06303a27 PS28, Line 22: REGION_SIZE(dram_wlan) / KiB); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117211): https://review.coreboot.org/c/coreboot/+/50587/comment/a0525656_12588b4b PS28, Line 24: REGION_SIZE(dram_wpss) / KiB); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117211): https://review.coreboot.org/c/coreboot/+/50587/comment/8bf35adc_1c3ff1cb PS28, Line 24: REGION_SIZE(dram_wpss) / KiB); please, no spaces at the start of a line