Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37767 )
Change subject: util/inteltool: drop OS-specific rdmsr functions ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37767/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37767/4//COMMIT_MSG@7 PS4, Line 7: rdmsr functions nit: rdmsr/wrmsr prototypes
https://review.coreboot.org/c/coreboot/+/37767/4//COMMIT_MSG@9 PS4, Line 9: Tested on: FreeBSD 13.0-CURRENT r355582 This should go after the commit message.
https://review.coreboot.org/c/coreboot/+/37767/4//COMMIT_MSG@12 PS4, Line 12: Maybe add that these prototypes need to be removed since that commit made rdmsr static. Also, it would be better to link to the SHA hash and commit summary, eg. 6faccd1f00 (util/inteltool: Make internal functions static), rather than the change id.