Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40964 )
Change subject: mb: Use common Winbond W83627DHG config entry/exit functions ......................................................................
Patch Set 5:
Patch Set 5:
Build failures:
CC bootblock/superio/smsc/smscsuperio/early_serial.o src/superio/smsc/smscsuperio/early_serial.c:14:13: error: static declaration of 'pnp_enter_conf_state' follows non-static declaration static void pnp_enter_conf_state(pnp_devfn_t dev) ^~~~~~~~~~~~~~~~~~~~ In file included from src/superio/smsc/smscsuperio/early_serial.c:4: src/include/device/pnp_ops.h:12:6: note: previous declaration of 'pnp_enter_conf_state' was here void pnp_enter_conf_state(pnp_devfn_t dev); ^~~~~~~~~~~~~~~~~~~~ src/superio/smsc/smscsuperio/early_serial.c:21:13: error: static declaration of 'pnp_exit_conf_state' follows non-static declaration static void pnp_exit_conf_state(pnp_devfn_t dev) ^~~~~~~~~~~~~~~~~~~ In file included from src/superio/smsc/smscsuperio/early_serial.c:4: src/include/device/pnp_ops.h:13:6: note: previous declaration of 'pnp_exit_conf_state' was here void pnp_exit_conf_state(pnp_devfn_t dev); ^~~~~~~~~~~~~~~~~~~
This depends on CB:40962, which was postponed due to breakage in google boards. Now I'm trying to force Jenkins to run again so it can tell me where the breakages were, but without much success.