Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36418 )
Change subject: cpu/x86: Introduce .near_reset_vector
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36418/3/src/cpu/x86/16bit/reset16.l...
File src/cpu/x86/16bit/reset16.ld:
https://review.coreboot.org/c/coreboot/+/36418/3/src/cpu/x86/16bit/reset16.l...
PS3, Line 29: #endif
Builds were section . […]
I agree it's cleaner without, however there were Apollo Lake boards failing the build. (Sorry if you already noticed that.) I don't know much about that tech, but Kconfig sets C_ENV_BOOTBLOCK_SIZE to 0x8000 and has a comment "32KiB bootblock is all that is mapped in by the CSE at top of 4GiB.". I infer APL cannot be larger than 0x8000 and doesn't have enough room for a 4K section at the top.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36418
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e7888c778e1d1cc426e4160543f4a4662ebf834
Gerrit-Change-Number: 36418
Gerrit-PatchSet: 5
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 21 Dec 2019 01:51:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment