[coreboot-gerrit] Change in ...coreboot[master]: soc/amd/stoneyridge: Move GPIO support to common

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32651 )

Change subject: soc/amd/stoneyridge: Move GPIO support to common
......................................................................

Patch Set 3: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/32651/2/src/mainboard/google/kahlee/mainboar... 
File src/mainboard/google/kahlee/mainboard.c:

https://review.coreboot.org/#/c/32651/2/src/mainboard/google/kahlee/mainboar... 
PS2, Line 30: <soc/smi.h>
            :
> > ...but seems to build OK w/o the addition. […]

I see, the original gpio.h included smi.h, the common gpio.h does not, thus it was needed to add it here. Also, smi.h never belonged to gpio.h, so you correctly removed it from gpio.h and added it here.