Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36492 )
Change subject: mainboard/google: Move variant_memory_sku() to baseboard/
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36492/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36492/1//COMMIT_MSG@9
PS1, Line 9: unreasonably
The request from me was to follow furquan's advice on CL:36250 on how to implement a single romstage […]
Edward, makes sense. I was trying to point how I was reading the various efforts and wording. Technically speaking, I think we're on the same page.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36492
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41532e3067a989db5776887fac0459a000d07ff0
Gerrit-Change-Number: 36492
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Daniel Kurtz
djkurtz@google.com
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-Comment-Date: Thu, 31 Oct 2019 06:46:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Daniel Kurtz
djkurtz@google.com
Gerrit-MessageType: comment