Attention is currently required from: Jason Glenesk, Marshall Dawson, Tim Wawrzynczak, Julius Werner, Andrey Petrov, Alexander Couzens, Patrick Rudolph, Yu-Ping Wu, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Tim Wawrzynczak, Julius Werner, Alexander Couzens, Andrey Petrov, Yu-Ping Wu, Patrick Rudolph, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58968
to look at the new patch set (#3).
Change subject: [WIP] drivers/mrc_cache: Drop get_write_protect_state() stubs ......................................................................
[WIP] drivers/mrc_cache: Drop get_write_protect_state() stubs
It should be optional to protect MRC_CACHE without CHROMEOS so MRC_SETTINGS_PROTECT cannot be enforced from soc/.
This change selects MRC_SETTINGS_PROTECT also for older platforms when CHROMEOS is selected.
If a board does not implement get_write_protect_state() MRC_SETTINGS_PROTECT should not be selected since the related SPI flash pages will not get protected. Currently, such real implementations may or may not be guarded with CONFIG(CHROMEOS) and the protection is only expected to work after followup works.
Change-Id: I8db0394645df1917b686339fa79432ccfc6960a2 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/drivers/mrc_cache/mrc_cache.c M src/ec/lenovo/h8/vboot.c M src/mainboard/amd/majolica/chromeos.c M src/mainboard/google/foster/chromeos.c M src/mainboard/intel/adlrvp/chromeos.c M src/mainboard/intel/coffeelake_rvp/chromeos.c M src/mainboard/intel/galileo/vboot.c M src/mainboard/intel/glkrvp/chromeos.c M src/mainboard/intel/icelake_rvp/chromeos.c M src/mainboard/intel/jasperlake_rvp/chromeos.c M src/mainboard/intel/kblrvp/chromeos.c M src/mainboard/intel/tglrvp/chromeos.c M src/mainboard/intel/wtm2/chromeos.c M src/security/vboot/bootmode.c M src/soc/intel/alderlake/Kconfig M src/soc/intel/apollolake/Kconfig M src/soc/intel/broadwell/Kconfig M src/soc/intel/cannonlake/Kconfig M src/soc/intel/elkhartlake/Kconfig M src/soc/intel/icelake/Kconfig M src/soc/intel/jasperlake/Kconfig M src/soc/intel/skylake/Kconfig M src/soc/intel/tigerlake/Kconfig M src/vendorcode/google/chromeos/Kconfig 24 files changed, 4 insertions(+), 92 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/58968/3