Attention is currently required from: Marc Jones, Jonathan Zhang, Jingle Hsu, Morgan Jang, Patrick Rudolph, Tim Chu.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49893 )
Change subject: xeon_sp/cpx: Update meminfo max_capacity_mib and number_of_devices
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/xeon_sp/cpx/romstage.c:
https://review.coreboot.org/c/coreboot/+/49893/comment/dc723148_dfdcd3c5
PS3, Line 24: uint32_t __weak mainboard_skt_memory_max_capacity_mib(void) { return 0; }
Does the really need a mainboard override? This should have a good default value for CPX.
In case this value is different among different CPX CPU models, so mainboard has a chance to set its own value accordingly. If it's 0 smbios.c would still calculate the current installed memory DIMMs sizes as the maximum memory capacity for type 16.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49893
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8f92dc96a7a3eb2e6db330adda98a7fe6d516c8
Gerrit-Change-Number: 49893
Gerrit-PatchSet: 3
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Wed, 27 Jan 2021 06:42:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marc Jones
marc@marcjonesconsulting.com
Gerrit-MessageType: comment