huayang duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32284 )
Change subject: mediatek/mt8183: fix mode register setting fail issue
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/#/c/32284/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32284/4//COMMIT_MSG@9
PS4, Line 9: the
The
Done
https://review.coreboot.org/#/c/32284/4/src/soc/mediatek/mt8183/dramc_init_s...
File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/#/c/32284/4/src/soc/mediatek/mt8183/dramc_init_s...
PS4, Line 21: #include <delay.h>
sort the include lines
Done
https://review.coreboot.org/#/c/32284/4/src/soc/mediatek/mt8183/dramc_init_s...
PS4, Line 668: dramc_mode_reg_init_sequence
This array should be mark as 'static' if it won't be access from any other file. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32284
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51785e90b2014994be5018bfe543245d44626242
Gerrit-Change-Number: 32284
Gerrit-PatchSet: 5
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Comment-Date: Sun, 05 May 2019 03:39:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: You-Cheng Syu
youcheng@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment