Attention is currently required from: Paul Menzel, chris wang.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48734 )
Change subject: mb/google/zork: add edp tunning parameter to fix the edp noise
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48734/comment/508e6dde_d8df7dfe
PS5, Line 30: register "edp_table_size" = "0x05"
haven't really figured out what this does on the fsp side exactly, but it does seem rather odd to me, since i have the impression that this is just the constant size of edp_tuningset
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48734
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe720e26d2257e05a989eaa1fd85d542005cf6a6
Gerrit-Change-Number: 48734
Gerrit-PatchSet: 5
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: chris wang
Chris.Wang@amd.com
Gerrit-Comment-Date: Thu, 14 Jan 2021 02:04:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment