Attention is currently required from: Meera Ravindranath.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48416 )
Change subject: mb/intel/adlrvp_p: Support VBT for LP4, LP5 and DDR5 SKUs
......................................................................
Patch Set 15:
(1 comment)
File src/mainboard/intel/adlrvp/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48416/comment/1de4d325_d418b29a
PS15, Line 22: add_vbt_to_cbfs= \
: $(eval cbfs-files-y += $1) \
: $(eval $1-file := $2) \
: $(eval $1-type := raw) \
: $(eval $1-compression := lzma)
This is already provided in https://review.coreboot.org/cgit/coreboot.git/tree/src/drivers/intel/gma/Mak.... Do you still need to define it again?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48416
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8795cc67d87429eddb31328f1e2a90c346b53533
Gerrit-Change-Number: 48416
Gerrit-PatchSet: 15
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Comment-Date: Mon, 22 Feb 2021 20:16:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment