build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39612 )
Change subject: sc7180: clock: Add display external clock in coreboot ......................................................................
Patch Set 28:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39612/28/src/soc/qualcomm/sc7180/cl... File src/soc/qualcomm/sc7180/clock.c:
https://review.coreboot.org/c/coreboot/+/39612/28/src/soc/qualcomm/sc7180/cl... PS28, Line 370: if (mdss_clk_cfg.m != 0) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/39612/28/src/soc/qualcomm/sc7180/cl... PS28, Line 379: ~(mdss_clk_cfg.d_2) & CLK_CTL_RCG_MND_BMSK); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39612/28/src/soc/qualcomm/sc7180/cl... PS28, Line 379: ~(mdss_clk_cfg.d_2) & CLK_CTL_RCG_MND_BMSK); please, no spaces at the start of a line