Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34599 )
Change subject: lib/coreboot_table: Show splashscreen in lb_table_init ......................................................................
Patch Set 12:
(3 comments)
"If at first you don't succeed, you try it all again" :)
https://review.coreboot.org/c/coreboot/+/34599/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34599/11//COMMIT_MSG@11 PS11, Line 11: fill_lb_framebuffer call.
The period already signifies the end of the sentence, please don't […]
Ack
https://review.coreboot.org/c/coreboot/+/34599/11//COMMIT_MSG@24 PS11, Line 24: a white screen - more investigation will be required.
What happens with Cirrus VGA in the payload? does the framebuffer […]
Yep. The cirrus framebuffer init appears to not be working on its own with some resolutions..
https://review.coreboot.org/c/coreboot/+/34599/11/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/34599/11/src/lib/coreboot_table.c@4... PS11, Line 49:
No multiple empty lines, please.
Done